This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/19674 ) Change subject: dfu: Save another 60 bytes by changing the way we print horizontal lines ...................................................................... dfu: Save another 60 bytes by changing the way we print horizontal lines Change-Id: I1660a04fb3e42200bc2fdd23aa114119620125a1 --- M firmware/apps/dfu/main.c 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index aa0adfd..f8c0c53 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -243,6 +243,17 @@ //board_exec_dbg_cmd(ch); } +/* print a horizontal line of '=' characters; Doing this in a loop vs. using a 'const' + * string saves us ~60 bytes of executable size (matters particularly for DFU loader) */ +static void print_line(void) +{ + int i; + for (i = 0; i < 78; i++) + fputc('=', stdout); + fputc('\n', stdout); + fputc('\r', stdout); +} + /*------------------------------------------------------------------------------ * Main *------------------------------------------------------------------------------*/ @@ -267,12 +278,12 @@ EEFC_ReadUniqueID(g_unique_id); - printf("\n\r\n\r" - "=============================================================================\n\r" - "DFU bootloader %s for board %s\n\r" - "(C) 2010-2017 by Harald Welte, 2018-2019 by Kevin Redon\n\r" - "=============================================================================\n\r", + printf("\n\r\n\r"); + print_line(); + printf("DFU bootloader %s for board %s\n\r" + "(C) 2010-2017 by Harald Welte, 2018-2019 by Kevin Redon\n\r", manifest_revision, manifest_board); + print_line(); #if (TRACE_LEVEL >= TRACE_LEVEL_INFO) TRACE_INFO("Chip ID: 0x%08lx (Ext 0x%08lx)\n\r", CHIPID->CHIPID_CIDR, CHIPID->CHIPID_EXID); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/19674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1660a04fb3e42200bc2fdd23aa114119620125a1 Gerrit-Change-Number: 19674 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200816/6414f968/attachment.htm>