<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/19674">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">dfu: Save another 60 bytes by changing the way we print horizontal lines<br><br>Change-Id: I1660a04fb3e42200bc2fdd23aa114119620125a1<br>---<br>M firmware/apps/dfu/main.c<br>1 file changed, 16 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c</span><br><span>index aa0adfd..f8c0c53 100644</span><br><span>--- a/firmware/apps/dfu/main.c</span><br><span>+++ b/firmware/apps/dfu/main.c</span><br><span>@@ -243,6 +243,17 @@</span><br><span>     //board_exec_dbg_cmd(ch);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* print a horizontal line of '=' characters; Doing this in a loop vs. using a 'const'</span><br><span style="color: hsl(120, 100%, 40%);">+ * string saves us ~60 bytes of executable size (matters particularly for DFU loader) */</span><br><span style="color: hsl(120, 100%, 40%);">+static void print_line(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+        for (i = 0; i < 78; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+           fputc('=', stdout);</span><br><span style="color: hsl(120, 100%, 40%);">+   fputc('\n', stdout);</span><br><span style="color: hsl(120, 100%, 40%);">+  fputc('\r', stdout);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*------------------------------------------------------------------------------</span><br><span>  *        Main</span><br><span>  *------------------------------------------------------------------------------*/</span><br><span>@@ -267,12 +278,12 @@</span><br><span> </span><br><span>    EEFC_ReadUniqueID(g_unique_id);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     printf("\n\r\n\r"</span><br><span style="color: hsl(0, 100%, 40%);">-             "=============================================================================\n\r"</span><br><span style="color: hsl(0, 100%, 40%);">-           "DFU bootloader %s for board %s\n\r"</span><br><span style="color: hsl(0, 100%, 40%);">-          "(C) 2010-2017 by Harald Welte, 2018-2019 by Kevin Redon\n\r"</span><br><span style="color: hsl(0, 100%, 40%);">-         "=============================================================================\n\r",</span><br><span style="color: hsl(120, 100%, 40%);">+        printf("\n\r\n\r");</span><br><span style="color: hsl(120, 100%, 40%);">+ print_line();</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("DFU bootloader %s for board %s\n\r"</span><br><span style="color: hsl(120, 100%, 40%);">+         "(C) 2010-2017 by Harald Welte, 2018-2019 by Kevin Redon\n\r",</span><br><span>             manifest_revision, manifest_board);</span><br><span style="color: hsl(120, 100%, 40%);">+   print_line();</span><br><span> </span><br><span> #if (TRACE_LEVEL >= TRACE_LEVEL_INFO)</span><br><span>        TRACE_INFO("Chip ID: 0x%08lx (Ext 0x%08lx)\n\r", CHIPID->CHIPID_CIDR, CHIPID->CHIPID_EXID);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/19674">change 19674</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/19674"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1660a04fb3e42200bc2fdd23aa114119620125a1 </div>
<div style="display:none"> Gerrit-Change-Number: 19674 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>