Change in libosmocore[master]: gsm_412 Cell Broadcast

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 6 17:55:38 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/11410 )

Change subject: gsm_412 Cell Broadcast
......................................................................


Patch Set 9: Code-Review-1

(5 comments)

CR-1 due to LE specific field order.

https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h 
File include/osmocom/gsm/protocol/gsm_04_12.h:

https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@48 
PS9, Line 48: ??
What should be here?


https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@56 
PS9, Line 56: gsm412_warning_type
This is only valid for little endian, please run 'libosmocore/contrib/struct_endianess.py'.


https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@84 
PS9, Line 84: gsm412_9_serial_nr
Same here.


https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@91 
PS9, Line 91: gsm412_9_page_param
And here.


https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@114 
PS9, Line 114: struct gsm412_
A missing structure or TODO?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/11410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd
Gerrit-Change-Number: 11410
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200806/646991b8/attachment.htm>


More information about the gerrit-log mailing list