<p style="white-space: pre-wrap; word-wrap: break-word;">CR-1 due to LE specific field order.</p><p>Patch set 9:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h">File include/osmocom/gsm/protocol/gsm_04_12.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@48">Patch Set #9, Line 48:</a> <code style="font-family:monospace,monospace">??</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What should be here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@56">Patch Set #9, Line 56:</a> <code style="font-family:monospace,monospace">gsm412_warning_type</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is only valid for little endian, please run 'libosmocore/contrib/struct_endianess.py'.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@84">Patch Set #9, Line 84:</a> <code style="font-family:monospace,monospace">gsm412_9_serial_nr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@91">Patch Set #9, Line 91:</a> <code style="font-family:monospace,monospace">gsm412_9_page_param</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">And here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/11410/9/include/osmocom/gsm/protocol/gsm_04_12.h@114">Patch Set #9, Line 114:</a> <code style="font-family:monospace,monospace">struct gsm412_</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">A missing structure or TODO?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/11410">change 11410</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/11410"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd </div>
<div style="display:none"> Gerrit-Change-Number: 11410 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Aug 2020 17:55:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>