Change in osmo-bsc[master]: BS-11: Fix "CONNECT TERRESTRIAL TRAFFIC"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Aug 1 15:30:40 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19491 )

Change subject: BS-11: Fix "CONNECT TERRESTRIAL TRAFFIC"
......................................................................

BS-11: Fix "CONNECT TERRESTRIAL TRAFFIC"

On a TS 12.21 spec compliant BTS, each Um traffic channel must be mapped
to an E1 sub-slot on the terrestrial back-haul.  This happens via
the CONNECT TERRESTRIAL TRAFFIC message.

We always had code to sen that message, but it got deactivated when
ts->pchan_is / ts->pchan_from_config was introduced.  Of course,
while we are bringing up OML, there is no 'pchan_is' set yet. We only
have 'pchan_from_config' and must use it.

Change-Id: I8988a027b0e897bd9dda460590f974d6be34a4fa
---
M src/osmo-bsc/bts_siemens_bs11.c
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c
index c808421..08694ea 100644
--- a/src/osmo-bsc/bts_siemens_bs11.c
+++ b/src/osmo-bsc/bts_siemens_bs11.c
@@ -404,9 +404,16 @@
 	if (is_ipaccess_bts(ts->trx->bts))
 		return;
 
-	if (ts_is_tch(ts))
-		abis_nm_conn_terr_traf(ts, e1l->e1_nr, e1l->e1_ts,
-					e1l->e1_ts_ss);
+	switch (ts->pchan_from_config) {
+	case GSM_PCHAN_TCH_F:
+		abis_nm_conn_terr_traf(ts, e1l->e1_nr, e1l->e1_ts, e1l->e1_ts_ss);
+		break;
+	case GSM_PCHAN_TCH_H:
+		LOG_TS(ts, LOGL_ERROR, "No support for half-rate over E1 yet!\n");
+		break;
+	default:
+		break;
+	}
 }
 
 static void nm_reconfig_trx(struct gsm_bts_trx *trx)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19491
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8988a027b0e897bd9dda460590f974d6be34a4fa
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200801/d6a47cf5/attachment.htm>


More information about the gerrit-log mailing list