<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19491">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BS-11: Fix "CONNECT TERRESTRIAL TRAFFIC"<br><br>On a TS 12.21 spec compliant BTS, each Um traffic channel must be mapped<br>to an E1 sub-slot on the terrestrial back-haul.  This happens via<br>the CONNECT TERRESTRIAL TRAFFIC message.<br><br>We always had code to sen that message, but it got deactivated when<br>ts->pchan_is / ts->pchan_from_config was introduced.  Of course,<br>while we are bringing up OML, there is no 'pchan_is' set yet. We only<br>have 'pchan_from_config' and must use it.<br><br>Change-Id: I8988a027b0e897bd9dda460590f974d6be34a4fa<br>---<br>M src/osmo-bsc/bts_siemens_bs11.c<br>1 file changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>index c808421..08694ea 100644</span><br><span>--- a/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>+++ b/src/osmo-bsc/bts_siemens_bs11.c</span><br><span>@@ -404,9 +404,16 @@</span><br><span>      if (is_ipaccess_bts(ts->trx->bts))</span><br><span>             return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (ts_is_tch(ts))</span><br><span style="color: hsl(0, 100%, 40%);">-              abis_nm_conn_terr_traf(ts, e1l->e1_nr, e1l->e1_ts,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        e1l->e1_ts_ss);</span><br><span style="color: hsl(120, 100%, 40%);">+    switch (ts->pchan_from_config) {</span><br><span style="color: hsl(120, 100%, 40%);">+   case GSM_PCHAN_TCH_F:</span><br><span style="color: hsl(120, 100%, 40%);">+         abis_nm_conn_terr_traf(ts, e1l->e1_nr, e1l->e1_ts, e1l->e1_ts_ss);</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case GSM_PCHAN_TCH_H:</span><br><span style="color: hsl(120, 100%, 40%);">+         LOG_TS(ts, LOGL_ERROR, "No support for half-rate over E1 yet!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span> }</span><br><span> </span><br><span> static void nm_reconfig_trx(struct gsm_bts_trx *trx)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19491">change 19491</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19491"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8988a027b0e897bd9dda460590f974d6be34a4fa </div>
<div style="display:none"> Gerrit-Change-Number: 19491 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>