Change in osmo-ttcn3-hacks[master]: PCU: introduce and use helper f_pcuif_tx_data_cnf()

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17968 )

Change subject: PCU: introduce and use helper f_pcuif_tx_data_cnf()
......................................................................

PCU: introduce and use helper f_pcuif_tx_data_cnf()

Change-Id: Icc23f4d0cd56f553aad81679d9d62243554402aa
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 14 insertions(+), 5 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 190da1d..09ff4e3 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -245,6 +245,18 @@
 	desc.final_ack := final_ack;
 }
 
+/* This function can be used to send DATA.cnf in response to the IUT originated DATA.req.
+ * NOTE: it's the responsibility of caller to make sure that pcu_msg contains u.data_req. */
+private function f_pcuif_tx_data_cnf(in PCUIF_Message pcu_msg)
+runs on RAW_PCU_Test_CT {
+	BTS.send(PCUIF_Message:{
+		msg_type := PCU_IF_MSG_DATA_CNF,
+		bts_nr := pcu_msg.bts_nr,
+		spare := pcu_msg.spare,
+		u := { data_cnf := pcu_msg.u.data_req }
+	});
+}
+
 private function f_pcuif_rx_imm_ass(out GsmRrMessage rr_imm_ass,
 				    template PCUIF_Sapi sapi := PCU_IF_SAPI_AGCH,
 				    template GsmRrMessage t_imm_ass := ?,
@@ -390,8 +402,7 @@
 		setverdict(fail, "Failed to match Immediate Assignment: ", rr_imm_ass);
 		mtc.stop;
 	}
-	BTS.send(ts_PCUIF_DATA_CNF(bts_nr := 0, trx_nr := 0, ts_nr := 0, block_nr := 0,
-				   fn := pcu_msg.u.data_req.fn, arfcn := 871, sapi := PCU_IF_SAPI_PCH, data := macblock));
+	f_pcuif_tx_data_cnf(pcu_msg);
 }
 
 /* Expect a Paging Request Type 1 from PCU on PCUIF on specified sapi.  */
@@ -427,9 +438,7 @@
 		mtc.stop;
 	}
 
-	BTS.send(ts_PCUIF_DATA_CNF(bts_nr := 0, trx_nr := 0, ts_nr := 0, block_nr := 0,
-				   fn := pcu_msg.u.data_req.fn, arfcn := 871, sapi := PCU_IF_SAPI_PCH, data := macblock));
-
+	f_pcuif_tx_data_cnf(pcu_msg);
 	return rr_pag_req1;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icc23f4d0cd56f553aad81679d9d62243554402aa
Gerrit-Change-Number: 17968
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200428/eb67257c/attachment.htm>