<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17968">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU: introduce and use helper f_pcuif_tx_data_cnf()<br><br>Change-Id: Icc23f4d0cd56f553aad81679d9d62243554402aa<br>---<br>M pcu/PCU_Tests_RAW.ttcn<br>1 file changed, 14 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn</span><br><span>index 190da1d..09ff4e3 100644</span><br><span>--- a/pcu/PCU_Tests_RAW.ttcn</span><br><span>+++ b/pcu/PCU_Tests_RAW.ttcn</span><br><span>@@ -245,6 +245,18 @@</span><br><span>    desc.final_ack := final_ack;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* This function can be used to send DATA.cnf in response to the IUT originated DATA.req.</span><br><span style="color: hsl(120, 100%, 40%);">+ * NOTE: it's the responsibility of caller to make sure that pcu_msg contains u.data_req. */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_pcuif_tx_data_cnf(in PCUIF_Message pcu_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS.send(PCUIF_Message:{</span><br><span style="color: hsl(120, 100%, 40%);">+              msg_type := PCU_IF_MSG_DATA_CNF,</span><br><span style="color: hsl(120, 100%, 40%);">+              bts_nr := pcu_msg.bts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+             spare := pcu_msg.spare,</span><br><span style="color: hsl(120, 100%, 40%);">+               u := { data_cnf := pcu_msg.u.data_req }</span><br><span style="color: hsl(120, 100%, 40%);">+       });</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_pcuif_rx_imm_ass(out GsmRrMessage rr_imm_ass,</span><br><span>                                     template PCUIF_Sapi sapi := PCU_IF_SAPI_AGCH,</span><br><span>                                template GsmRrMessage t_imm_ass := ?,</span><br><span>@@ -390,8 +402,7 @@</span><br><span>              setverdict(fail, "Failed to match Immediate Assignment: ", rr_imm_ass);</span><br><span>            mtc.stop;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       BTS.send(ts_PCUIF_DATA_CNF(bts_nr := 0, trx_nr := 0, ts_nr := 0, block_nr := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                            fn := pcu_msg.u.data_req.fn, arfcn := 871, sapi := PCU_IF_SAPI_PCH, data := macblock));</span><br><span style="color: hsl(120, 100%, 40%);">+    f_pcuif_tx_data_cnf(pcu_msg);</span><br><span> }</span><br><span> </span><br><span> /* Expect a Paging Request Type 1 from PCU on PCUIF on specified sapi.  */</span><br><span>@@ -427,9 +438,7 @@</span><br><span>           mtc.stop;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   BTS.send(ts_PCUIF_DATA_CNF(bts_nr := 0, trx_nr := 0, ts_nr := 0, block_nr := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                            fn := pcu_msg.u.data_req.fn, arfcn := 871, sapi := PCU_IF_SAPI_PCH, data := macblock));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+    f_pcuif_tx_data_cnf(pcu_msg);</span><br><span>        return rr_pag_req1;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17968">change 17968</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17968"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc23f4d0cd56f553aad81679d9d62243554402aa </div>
<div style="display:none"> Gerrit-Change-Number: 17968 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>