Change in osmo-ttcn3-hacks[master]: Add GTPv2_Emulation component

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867 )

Change subject: Add GTPv2_Emulation component
......................................................................


Patch Set 3: Code-Review+1

(5 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn 
File library/GTPv2_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@236 
PS3, Line 236: explict IE members
:/


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@378 
PS3, Line 378: GTPv2_CodecPort_CtrlFunct
This prefix may be omitted since we 'import all' anyway.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@393 
PS3, Line 393: UECUPS_CodecPort_CtrlFunct
same here


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@405 
PS3, Line 405: activate(as_uecups_ind());
So this altstep is activated regardless of 'g_gtp2_cfg.use_gtpu_daemon'?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@473 
PS3, Line 473: g2c.sequenceNumber := int2oct(g_c_seq_nr, 3);
             : 		g_c_seq_nr := g_c_seq_nr + 1;
Would be nice to have a function like 'f_get_seq_nr() return OCT3', so we never forget to increment the counter.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If73aa453e44ebf28032c60d207feb03e8061dc0c
Gerrit-Change-Number: 17867
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 19 Apr 2020 23:51:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200419/3dee6567/attachment.htm>