<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn">File library/GTPv2_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@236">Patch Set #3, Line 236:</a> <code style="font-family:monospace,monospace">explict IE members</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">:/</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@378">Patch Set #3, Line 378:</a> <code style="font-family:monospace,monospace">GTPv2_CodecPort_CtrlFunct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This prefix may be omitted since we 'import all' anyway.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@393">Patch Set #3, Line 393:</a> <code style="font-family:monospace,monospace">UECUPS_CodecPort_CtrlFunct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@405">Patch Set #3, Line 405:</a> <code style="font-family:monospace,monospace">activate(as_uecups_ind());</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So this altstep is activated regardless of 'g_gtp2_cfg.use_gtpu_daemon'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867/3/library/GTPv2_Emulation.ttcn@473">Patch Set #3, Line 473:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">g2c.sequenceNumber := int2oct(g_c_seq_nr, 3);<br>           g_c_seq_nr := g_c_seq_nr + 1;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would be nice to have a function like 'f_get_seq_nr() return OCT3', so we never forget to increment the counter.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867">change 17867</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17867"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If73aa453e44ebf28032c60d207feb03e8061dc0c </div>
<div style="display:none"> Gerrit-Change-Number: 17867 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 19 Apr 2020 23:51:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>