Change in libosmocore[master]: tests/coding: Test decoding of DL EGPRS data packet

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Apr 7 23:31:58 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17750 )

Change subject: tests/coding: Test decoding of DL EGPRS data packet
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c 
File tests/coding/coding_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@326 
PS1, Line 326: struct
static const?


https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@328 
PS1, Line 328: false
How about using designated initializers?

  .is_egprs = false,
  .exp_burst_bits = GSM0503_GPRS_BURSTS_NBITS,
  // ...


https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@388 
PS1, Line 388: struct
const?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ide23a484b980995f24092d1cfbf062aed58fdf61
Gerrit-Change-Number: 17750
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 23:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200407/67f246e3/attachment.htm>


More information about the gerrit-log mailing list