<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17750">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c">File tests/coding/coding_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@326">Patch Set #1, Line 326:</a> <code style="font-family:monospace,monospace">struct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@328">Patch Set #1, Line 328:</a> <code style="font-family:monospace,monospace">false</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about using designated initializers?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  .is_egprs = false,<br>  .exp_burst_bits = GSM0503_GPRS_BURSTS_NBITS,<br>  // ...</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/17750/1/tests/coding/coding_test.c@388">Patch Set #1, Line 388:</a> <code style="font-family:monospace,monospace">struct</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">const?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17750">change 17750</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17750"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide23a484b980995f24092d1cfbf062aed58fdf61 </div>
<div style="display:none"> Gerrit-Change-Number: 17750 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Apr 2020 23:31:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>