Change in osmo-gsm-tester[master]: enb: add measurement modifier to scenario files

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744 )

Change subject: enb: add measurement modifier to scenario files
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas-event%40.conf 
File example/scenarios/mod-enb-meas-event at .conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas-event%40.conf@2 
PS3, Line 2:   enb:
Move enable_measurements: true here


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas.conf 
File example/scenarios/mod-enb-meas.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas.conf@1 
PS3, Line 1: modifiers:
This one is not needed


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl 
File src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl@233 
PS3, Line 233: % if enb.get('enable_measurements') == 'True':
% if enb.enable_measurements:

If you have issues with it being a string, then convert it in the python code better.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ia7657be2396886840570bc41645450a268b4cfff
Gerrit-Change-Number: 17744
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 14:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200407/7cf5ae17/attachment.htm>