<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas-event%40.conf">File example/scenarios/mod-enb-meas-event@.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas-event%40.conf@2">Patch Set #3, Line 2:</a> <code style="font-family:monospace,monospace">  enb:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Move enable_measurements: true here</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas.conf">File example/scenarios/mod-enb-meas.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/example/scenarios/mod-enb-meas.conf@1">Patch Set #3, Line 1:</a> <code style="font-family:monospace,monospace">modifiers:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This one is not needed</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl">File src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/3/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl@233">Patch Set #3, Line 233:</a> <code style="font-family:monospace,monospace">% if enb.get('enable_measurements') == 'True':</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">% if enb.enable_measurements:</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you have issues with it being a string, then convert it in the python code better.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744">change 17744</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia7657be2396886840570bc41645450a268b4cfff </div>
<div style="display:none"> Gerrit-Change-Number: 17744 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Apr 2020 14:50:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>