Change in osmo-gsm-tester[master]: enb: add measurement config scenario files

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744 )

Change subject: enb: add measurement config scenario files
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/example/scenarios/cfg-enb-meas-a1%40.conf 
File example/scenarios/cfg-enb-meas-a1 at .conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/example/scenarios/cfg-enb-meas-a1%40.conf@3 
PS1, Line 3:     a1_report_type: ${param1}
Why not making one scenario conf out of the 4 you introduce?
config:
  enb:
    enable_measurements: true
    ${param1}_report_type: ${param2}
    ${param1}_rsrp: ${param3}
    ${param1}_hysteresis: ${param4}
    ${param1}_time_to_trigger: ${param5}


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/src/osmo_gsm_tester/resource.py 
File src/osmo_gsm_tester/resource.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/src/osmo_gsm_tester/resource.py@127 
PS1, Line 127:       'config.enb.enable_measurements': schema.BOOL_STR,
I'd better put this under RESOURCE_SCHEMA as use "modifier". This way it can be configured per ENB.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ia7657be2396886840570bc41645450a268b4cfff
Gerrit-Change-Number: 17744
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Apr 2020 12:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200407/5d6e27c4/attachment.htm>