<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/example/scenarios/cfg-enb-meas-a1%40.conf">File example/scenarios/cfg-enb-meas-a1@.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/example/scenarios/cfg-enb-meas-a1%40.conf@3">Patch Set #1, Line 3:</a> <code style="font-family:monospace,monospace">    a1_report_type: ${param1}</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Why not making one scenario conf out of the 4 you introduce?<br>config:<br>  enb:<br>    enable_measurements: true<br>    ${param1}_report_type: ${param2}<br>    ${param1}_rsrp: ${param3}<br>    ${param1}_hysteresis: ${param4}<br>    ${param1}_time_to_trigger: ${param5}</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/src/osmo_gsm_tester/resource.py">File src/osmo_gsm_tester/resource.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744/1/src/osmo_gsm_tester/resource.py@127">Patch Set #1, Line 127:</a> <code style="font-family:monospace,monospace">      'config.enb.enable_measurements': schema.BOOL_STR,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd better put this under RESOURCE_SCHEMA as use "modifier". This way it can be configured per ENB.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744">change 17744</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17744"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia7657be2396886840570bc41645450a268b4cfff </div>
<div style="display:none"> Gerrit-Change-Number: 17744 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Apr 2020 12:57:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>