Change in osmo-bsc[master]: vty: clarify EGPRS Packet Channel Request message support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Apr 6 13:24:15 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17730 )

Change subject: vty: clarify EGPRS Packet Channel Request message support
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h 
File include/osmocom/bsc/rest_octets.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@a85 
PS1, Line 85: supports_egprs_11bit_rach
This parameter is a duplicate of...


https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@a91 
PS1, Line 91: use_egprs_p_ch_req
this parameter.


https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@85 
PS1, Line 85: 	bool ctrl_ack_type_use_block; /* use PACKET CONTROL ACKNOWLEDGMENT */
> https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/gsm_data. […]
This structure is an abstract representation of GPRS Cell Options IE, while your link points to a sub-structure of 'gsm_bts', where we store some GPRS specific parameters (some of them configured from the VTY). I am just removing duplication within the same structure...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ied5bd10a806aeeac65ef32339d4ab0e3700e5da9
Gerrit-Change-Number: 17730
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Apr 2020 13:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200406/95971323/attachment.htm>


More information about the gerrit-log mailing list