<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h">File include/osmocom/bsc/rest_octets.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@a85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace">supports_egprs_11bit_rach</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This parameter is a duplicate of...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@a91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace">use_egprs_p_ch_req</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this parameter.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace">       bool ctrl_ack_type_use_block; /* use PACKET CONTROL ACKNOWLEDGMENT */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/gsm_data. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This structure is an abstract representation of GPRS Cell Options IE, while your link points to a sub-structure of 'gsm_bts', where we store some GPRS specific parameters (some of them configured from the VTY). I am just removing duplication within the same structure...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730">change 17730</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ied5bd10a806aeeac65ef32339d4ab0e3700e5da9 </div>
<div style="display:none"> Gerrit-Change-Number: 17730 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Apr 2020 13:24:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>