Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic As...

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620 )

Change subject: PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic Assignment
......................................................................

PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic Assignment

According to 3GPP TS 44.018, section 10.5.2.16 "IA Rest Octets",
Packet Uplink Assignment can be either of the following types:

  - single block allocation,
  - dynamic allocation.

The current version of TC_cs_lqual_ul_tbf does not handle single
block allocation, so we need to make sure we got a TBF with
dynamic allocation.

Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 15a9cf6..6b45af2 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -631,7 +631,6 @@
 	}
 
 	/* Make sure we received an UL TBF Assignment */
-	/* TODO: check if we got single or dynamic assignment */
 	if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)))) {
 		ul_tbf_ass := rr_msg.payload.imm_ass.rest_octets.hh.pa.uldl.ass.ul;
 		log("Rx Uplink TBF assignment: ", ul_tbf_ass);
@@ -641,6 +640,12 @@
 		mtc.stop;
 	}
 
+	/* Make sure we have got a TBF with Dynamic Block Allocation */
+	if (ul_tbf_ass.dynamic == omit) {
+		setverdict(fail, "Single Block Allocation is not handled by ", testcasename());
+		mtc.stop;
+	}
+
 	var template (value) RlcmacUlBlock ul_data := t_RLCMAC_UL_DATA(
 		tfi := ul_tbf_ass.dynamic.tfi_assignment,
 		cv := 15, /* 15 UL blocks to be sent (to be overridden in loop) */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190929/af43469c/attachment.htm>