<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU_Tests_RAW.ttcn: TC_cs_lqual_ul_tbf: properly check for Dynamic Assignment<br><br>According to 3GPP TS 44.018, section 10.5.2.16 "IA Rest Octets",<br>Packet Uplink Assignment can be either of the following types:<br><br>  - single block allocation,<br>  - dynamic allocation.<br><br>The current version of TC_cs_lqual_ul_tbf does not handle single<br>block allocation, so we need to make sure we got a TBF with<br>dynamic allocation.<br><br>Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182<br>---<br>M pcu/PCU_Tests_RAW.ttcn<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn</span><br><span>index 15a9cf6..6b45af2 100644</span><br><span>--- a/pcu/PCU_Tests_RAW.ttcn</span><br><span>+++ b/pcu/PCU_Tests_RAW.ttcn</span><br><span>@@ -631,7 +631,6 @@</span><br><span>        }</span><br><span> </span><br><span>        /* Make sure we received an UL TBF Assignment */</span><br><span style="color: hsl(0, 100%, 40%);">-        /* TODO: check if we got single or dynamic assignment */</span><br><span>     if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)))) {</span><br><span>          ul_tbf_ass := rr_msg.payload.imm_ass.rest_octets.hh.pa.uldl.ass.ul;</span><br><span>          log("Rx Uplink TBF assignment: ", ul_tbf_ass);</span><br><span>@@ -641,6 +640,12 @@</span><br><span>              mtc.stop;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Make sure we have got a TBF with Dynamic Block Allocation */</span><br><span style="color: hsl(120, 100%, 40%);">+       if (ul_tbf_ass.dynamic == omit) {</span><br><span style="color: hsl(120, 100%, 40%);">+             setverdict(fail, "Single Block Allocation is not handled by ", testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+             mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  var template (value) RlcmacUlBlock ul_data := t_RLCMAC_UL_DATA(</span><br><span>              tfi := ul_tbf_ass.dynamic.tfi_assignment,</span><br><span>            cv := 15, /* 15 UL blocks to be sent (to be overridden in loop) */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620">change 15620</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15620"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I05cf0c62d21094fb53a9e5e54b404f3cf972a182 </div>
<div style="display:none"> Gerrit-Change-Number: 15620 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>