This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context ...................................................................... Patch Set 4: > > I still don't get why this has any mention of PCU in it. > > Well, I'm reading out the L1 SAPI from the "struct gsm_pcu_if", so > I can set the L1 SAPI log context for all incoming and outgoing L1 > messages from BTS<-->PCU. But where and why does the PCU get into the picture? I still don't understand. The L1 SAPI exists for every block of data we send or receive to/from the DSP/PHY, whether or not it's circuit switched or packet switched. And the PCU interface will ever only get packet switched data. So anything that's attached/associated to the PCU interface will only see a very small portion of the traffic (i.e. GPRS traffic). > Sorry, I had assumed, that in OsmoBTS, this L1 SAPI logging would > only be relevant for the BTS<-->PCU socket, and therefore thought > the appropriate log context would be what is defined with > PCU_IF_SAPI_*. I wonder where that impression was raised? The L1 is not used only by the PCU, but by all of OsmoBTS. > From what I understand now, instead I need to do this: > * create a new enum in libosmocore that holds all kinds of L1 SAPI > values that may be an option, but I'm not sure it's required to have this in libosmocore. After all, there is no need for those values / enums to be stable across different programs. Those enum values are never exposed on any external interface/API, so they could just be private enums in both BTS and PCU. > * don't use "pcu_prim->...sapi" directly to set the filter context, > but translate it to the enum first correct. > * set the log context in other places in OSmoBTS, that are not > related to the PCU (that must be the other side, when talking to > hardware backends) You need to set that value for every L1P (and possibly L1C?) primitive received from the respective PHY, as soon as possible. That's for the uplink part. For downlink, I suspect it's sufficient to set it based on chan_nr when received from L1SAP. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b Gerrit-Change-Number: 15539 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 19 Sep 2019 15:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190919/768e9074/attachment.htm>