This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context ...................................................................... Patch Set 4: > I still don't get why this has any mention of PCU in it. Well, I'm reading out the L1 SAPI from the "struct gsm_pcu_if", so I can set the L1 SAPI log context for all incoming and outgoing L1 messages from BTS<-->PCU. > the L1 SAPI value can have many other values that have nothing to do with the PCU. Sorry, I had assumed, that in OsmoBTS, this L1 SAPI logging would only be relevant for the BTS<-->PCU socket, and therefore thought the appropriate log context would be what is defined with PCU_IF_SAPI_*. >From what I understand now, instead I need to do this: * create a new enum in libosmocore that holds all kinds of L1 SAPI values * don't use "pcu_prim->...sapi" directly to set the filter context, but translate it to the enum first * set the log context in other places in OSmoBTS, that are not related to the PCU (that must be the other side, when talking to hardware backends) Is this correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b Gerrit-Change-Number: 15539 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 13:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/06885530/attachment.htm>