Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix: IA Rest Octets is mandatory IE

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15428 )

Change subject: library/GSM_RR_Types.ttcn: fix: IA Rest Octets is mandatory IE
......................................................................

library/GSM_RR_Types.ttcn: fix: IA Rest Octets is mandatory IE

According to 3GPP TS 04.08 (version 7.21.0), table 9.18, IA Rest
Octets (see 10.5.2.16) is a mandatory IE, not optional.

Change-Id: I403d2141536303a966be7ff51b06c3de202412e6
---
M library/GSM_RR_Types.ttcn
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 457f0f5..627f78f 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -587,7 +587,7 @@
 		TimingAdvance			timing_advance,
 		MobileAllocation		mobile_allocation,
 		/* TODO: starting time TLV */
-		IaRestOctets			rest_octets optional
+		IaRestOctets			rest_octets
 	} with { variant (chan_desc) "PRESENCE(ded_or_tbf.tbf = false)"
 		 variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)" };
 
@@ -737,7 +737,14 @@
 				req_ref := f_compute_ReqRef(ra, fn),
 				timing_advance := ta,
 				mobile_allocation := ma,
-				rest_octets := omit
+				rest_octets := {
+					presence := '00'B, /* LL */
+					ll := {
+						/* Compressed INTER RAT HO INFO: shall not be used (L)
+						 * TODO: use variant "CSN.1 L/H" to avoid confusion. */
+						compressed_irat_ho_info_ind := '1'B
+					}
+				}
 			}
 		}
 	};
@@ -761,7 +768,7 @@
 				req_ref := tr_compute_ReqRef(ra, fn),
 				timing_advance := ta,
 				mobile_allocation := ma,
-				rest_octets := *
+				rest_octets := ?
 			}
 		}
 	};

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I403d2141536303a966be7ff51b06c3de202412e6
Gerrit-Change-Number: 15428
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190905/4cdac073/attachment.htm>