<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15428">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types.ttcn: fix: IA Rest Octets is mandatory IE<br><br>According to 3GPP TS 04.08 (version 7.21.0), table 9.18, IA Rest<br>Octets (see 10.5.2.16) is a mandatory IE, not optional.<br><br>Change-Id: I403d2141536303a966be7ff51b06c3de202412e6<br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index 457f0f5..627f78f 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -587,7 +587,7 @@</span><br><span>              TimingAdvance                   timing_advance,</span><br><span>              MobileAllocation                mobile_allocation,</span><br><span>           /* TODO: starting time TLV */</span><br><span style="color: hsl(0, 100%, 40%);">-           IaRestOctets                    rest_octets optional</span><br><span style="color: hsl(120, 100%, 40%);">+          IaRestOctets                    rest_octets</span><br><span>  } with { variant (chan_desc) "PRESENCE(ded_or_tbf.tbf = false)"</span><br><span>             variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)" };</span><br><span> </span><br><span>@@ -737,7 +737,14 @@</span><br><span>                           req_ref := f_compute_ReqRef(ra, fn),</span><br><span>                                 timing_advance := ta,</span><br><span>                                mobile_allocation := ma,</span><br><span style="color: hsl(0, 100%, 40%);">-                                rest_octets := omit</span><br><span style="color: hsl(120, 100%, 40%);">+                           rest_octets := {</span><br><span style="color: hsl(120, 100%, 40%);">+                                      presence := '00'B, /* LL */</span><br><span style="color: hsl(120, 100%, 40%);">+                                   ll := {</span><br><span style="color: hsl(120, 100%, 40%);">+                                               /* Compressed INTER RAT HO INFO: shall not be used (L)</span><br><span style="color: hsl(120, 100%, 40%);">+                                                 * TODO: use variant "CSN.1 L/H" to avoid confusion. */</span><br><span style="color: hsl(120, 100%, 40%);">+                                             compressed_irat_ho_info_ind := '1'B</span><br><span style="color: hsl(120, 100%, 40%);">+                                   }</span><br><span style="color: hsl(120, 100%, 40%);">+                             }</span><br><span>                    }</span><br><span>            }</span><br><span>    };</span><br><span>@@ -761,7 +768,7 @@</span><br><span>                             req_ref := tr_compute_ReqRef(ra, fn),</span><br><span>                                timing_advance := ta,</span><br><span>                                mobile_allocation := ma,</span><br><span style="color: hsl(0, 100%, 40%);">-                                rest_octets := *</span><br><span style="color: hsl(120, 100%, 40%);">+                              rest_octets := ?</span><br><span>                     }</span><br><span>            }</span><br><span>    };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15428">change 15428</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15428"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I403d2141536303a966be7ff51b06c3de202412e6 </div>
<div style="display:none"> Gerrit-Change-Number: 15428 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>