This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 )
Change subject: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@525
PS2, Line 525: function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 0, boolean initial := false) runs on BSSGP_ConnHdlr {
> May have more sense to have an array of initial states (boolean) in BSSGP_ConnHdlr with size equal t […]
good idea. @laforge, what do you think about this?
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@644
PS2, Line 644: var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
> why is this commented?
0 means UIA1. I'll change the comment to be more specific
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@646
PS2, Line 646: //BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
> why is this commented out? because sgsn should send it but it doesn't?
there is a seperate patch for this later in the chain.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433
Gerrit-Change-Number: 15171
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/eea4b018/attachment.htm>