Change in ...osmo-ttcn3-hacks[master]: sgsn: introduce f_send_l3() to allow one function for Gb & Iu

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 )

Change subject: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/#/c/15171/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15171/2//COMMIT_MSG@10 
PS2, Line 10: which sends L3 messages for Iu and Gb at the same time.
Not at the same time. It sends L3 messages over the requested L2 layer (controlled by gb_index).


https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn 
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@525 
PS2, Line 525: function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 0, boolean initial := false) runs on BSSGP_ConnHdlr {
May have more sense to have an array of initial states (boolean) in BSSGP_ConnHdlr with size equal to values available in gb_index (btw, can we call it ran_index?). This way initial state is maintained inside this function and tests don't need to care about whether they are sending initial message or not (and they can still play with the value by modifying the array directly if needed).


https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@644 
PS2, Line 644: 				var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
why is this commented?


https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@646 
PS2, Line 646: 				//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
why is this commented out? because sgsn should send it but it doesn't?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433
Gerrit-Change-Number: 15171
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/8b80156c/attachment.htm>