Change in ...osmo-ttcn3-hacks[master]: sgsn: extend f_routing_area_update() to support Iu

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396 )

Change subject: sgsn: extend f_routing_area_update() to support Iu
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn 
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2358 
PS1, Line 2358: friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer bssgp := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
Is ptmsi sent only on Iu? Then why not simply do inside the function:
if (is_iu(bssgp))
    p_tmsi := g_pars.p_tmsi;


https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2391 
PS1, Line 2391: 			var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
Again, why all these commented stuff?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b
Gerrit-Change-Number: 15396
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:40:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/4678d97d/attachment.htm>