<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn">File sgsn/SGSN_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2358">Patch Set #1, Line 2358:</a> <code style="font-family:monospace,monospace">friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer bssgp := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Is ptmsi sent only on Iu? Then why not simply do inside the function:<br>if (is_iu(bssgp))<br>    p_tmsi := g_pars.p_tmsi;</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2391">Patch Set #1, Line 2391:</a> <code style="font-family:monospace,monospace">                        var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Again, why all these commented stuff?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396">change 15396</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b </div>
<div style="display:none"> Gerrit-Change-Number: 15396 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 03 Sep 2019 18:40:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>