Change in libosmocore[master]: l1sap: add measurement related struct memebers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 31 17:47:17 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15888 )

Change subject: l1sap: add measurement related struct memebers
......................................................................


Patch Set 2:

(3 comments)

This change breaks ABI, please update TODO-RELEASE.

https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG@9 
PS2, Line 9: disolve
disSolve


https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h 
File include/osmocom/gsm/l1sap.h:

https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@87 
PS2, Line 87: flags
What is the purpose of these flags? And why only one bit?


https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@99 
PS2, Line 99: ta_offs_qbits
Do we really need this field in the new API? Basically, QTA == (ToA256 >> 6).



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42
Gerrit-Change-Number: 15888
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 17:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191031/969062c3/attachment.htm>


More information about the gerrit-log mailing list