<p style="white-space: pre-wrap; word-wrap: break-word;">This change breaks ABI, please update TODO-RELEASE.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888/2//COMMIT_MSG@9">Patch Set #2, Line 9:</a> <code style="font-family:monospace,monospace">disolve</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">disSolve</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h">File include/osmocom/gsm/l1sap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@87">Patch Set #2, Line 87:</a> <code style="font-family:monospace,monospace">flags</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What is the purpose of these flags? And why only one bit?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15888/2/include/osmocom/gsm/l1sap.h@99">Patch Set #2, Line 99:</a> <code style="font-family:monospace,monospace">ta_offs_qbits</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we really need this field in the new API? Basically, QTA == (ToA256 >> 6).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/15888">change 15888</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/15888"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42 </div>
<div style="display:none"> Gerrit-Change-Number: 15888 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 31 Oct 2019 17:47:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>