Change in libosmo-sccp[master]: xua_rkm: Don't permit de-registration of rctx with ASP active

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15832 )

Change subject: xua_rkm: Don't permit de-registration of rctx with ASP active
......................................................................

xua_rkm: Don't permit de-registration of rctx with ASP active

Change-Id: Ie47eb205b397f3d2ce94c4ec3531664ed290a819
Closes: OS#4238
---
M src/xua_rkm.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index 976d649..2d8a25e 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -30,6 +30,7 @@
 
 #include "xua_internal.h"
 #include "xua_as_fsm.h"
+#include "xua_asp_fsm.h"
 
 const struct value_string m3ua_rkm_reg_status_vals[] = {
 	{ M3UA_RKM_REG_SUCCESS,			"SUCCESS" },
@@ -338,7 +339,11 @@
 		return -1;
 	}
 
-	/* FIXME Reject if any ASP stillactively using this RCTX */
+	/* Reject if ASP is still active */
+	if (asp->fi->state == XUA_ASP_S_ACTIVE) {
+		msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_ASP_ACTIVE, 0);
+		return -1;
+	}
 
 	rt = osmo_ss7_route_find_dpc(inst->rtable_system, as->cfg.routing_key.pc);
 	if (!rt) {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ie47eb205b397f3d2ce94c4ec3531664ed290a819
Gerrit-Change-Number: 15832
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/550df940/attachment.htm>