<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15832">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">xua_rkm: Don't permit de-registration of rctx with ASP active<br><br>Change-Id: Ie47eb205b397f3d2ce94c4ec3531664ed290a819<br>Closes: OS#4238<br>---<br>M src/xua_rkm.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_rkm.c b/src/xua_rkm.c</span><br><span>index 976d649..2d8a25e 100644</span><br><span>--- a/src/xua_rkm.c</span><br><span>+++ b/src/xua_rkm.c</span><br><span>@@ -30,6 +30,7 @@</span><br><span> </span><br><span> #include "xua_internal.h"</span><br><span> #include "xua_as_fsm.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "xua_asp_fsm.h"</span><br><span> </span><br><span> const struct value_string m3ua_rkm_reg_status_vals[] = {</span><br><span>   { M3UA_RKM_REG_SUCCESS,                 "SUCCESS" },</span><br><span>@@ -338,7 +339,11 @@</span><br><span>                return -1;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* FIXME Reject if any ASP stillactively using this RCTX */</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Reject if ASP is still active */</span><br><span style="color: hsl(120, 100%, 40%);">+   if (asp->fi->state == XUA_ASP_S_ACTIVE) {</span><br><span style="color: hsl(120, 100%, 40%);">+               msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_ASP_ACTIVE, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+                return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        rt = osmo_ss7_route_find_dpc(inst->rtable_system, as->cfg.routing_key.pc);</span><br><span>     if (!rt) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15832">change 15832</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15832"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie47eb205b397f3d2ce94c4ec3531664ed290a819 </div>
<div style="display:none"> Gerrit-Change-Number: 15832 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>