Change in osmo-msc[master]: fsm: use deferred deallocation and term_stops_actions

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15850 )


Change subject: fsm: use deferred deallocation and term_stops_actions
......................................................................

fsm: use deferred deallocation and term_stops_actions

Since osmo-bsc uses the MGCP client FSMs, it is required to enable these new
features to guarantee safe operation. The issue is described in detail in
commit logs linked below.

Notably, osmo-msc currently chooses to omit error handling during MGCP events
(marked "FIXME"). An upcoming patch implements this error handling, and would
make osmo-msc vulnerable to crash from unexpected MGCP messages.

Depends: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 (libosmocore),
         I0adc13a1a998e953b6c850efa2761350dd07e03a (libosmocore)
Related: I7df2e9202b04e7ca7366bb0a8ec53cf3bb14faf3 (osmo-mgw)
Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a
---
M src/osmo-msc/msc_main.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/50/15850/1

diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 3860589..b08126f 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -500,7 +500,8 @@
 	/* Track the use of talloc NULL memory contexts */
 	talloc_enable_null_tracking();
 
-	osmo_fsm_term_safely(true);
+	osmo_fsm_set_dealloc_ctx(OTC_SELECT);
+	osmo_fsm_set_term_stops_actions(true);
 
 	msc_vty_info.copyright	= osmomsc_copyright;
 
@@ -721,7 +722,7 @@
 
 	while (!quit) {
 		log_reset_context();
-		osmo_select_main(0);
+		osmo_select_main_ctx(0);
 	}
 
 	msc_network_shutdown(msc_network);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a
Gerrit-Change-Number: 15850
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/8401a4a0/attachment.htm>