<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15850">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fsm: use deferred deallocation and term_stops_actions<br><br>Since osmo-bsc uses the MGCP client FSMs, it is required to enable these new<br>features to guarantee safe operation. The issue is described in detail in<br>commit logs linked below.<br><br>Notably, osmo-msc currently chooses to omit error handling during MGCP events<br>(marked "FIXME"). An upcoming patch implements this error handling, and would<br>make osmo-msc vulnerable to crash from unexpected MGCP messages.<br><br>Depends: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 (libosmocore),<br>         I0adc13a1a998e953b6c850efa2761350dd07e03a (libosmocore)<br>Related: I7df2e9202b04e7ca7366bb0a8ec53cf3bb14faf3 (osmo-mgw)<br>Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a<br>---<br>M src/osmo-msc/msc_main.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/50/15850/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c</span><br><span>index 3860589..b08126f 100644</span><br><span>--- a/src/osmo-msc/msc_main.c</span><br><span>+++ b/src/osmo-msc/msc_main.c</span><br><span>@@ -500,7 +500,8 @@</span><br><span>         /* Track the use of talloc NULL memory contexts */</span><br><span>   talloc_enable_null_tracking();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      osmo_fsm_term_safely(true);</span><br><span style="color: hsl(120, 100%, 40%);">+   osmo_fsm_set_dealloc_ctx(OTC_SELECT);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_fsm_set_term_stops_actions(true);</span><br><span> </span><br><span>   msc_vty_info.copyright  = osmomsc_copyright;</span><br><span> </span><br><span>@@ -721,7 +722,7 @@</span><br><span> </span><br><span>   while (!quit) {</span><br><span>              log_reset_context();</span><br><span style="color: hsl(0, 100%, 40%);">-            osmo_select_main(0);</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_select_main_ctx(0);</span><br><span>     }</span><br><span> </span><br><span>        msc_network_shutdown(msc_network);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15850">change 15850</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15850"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I08c03946605aa12e0a5ce8b3c773704ef5327a7a </div>
<div style="display:none"> Gerrit-Change-Number: 15850 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>