This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15810 ) Change subject: ipa: Don't send non-SCCP data over IPA/SCCPlite ...................................................................... ipa: Don't send non-SCCP data over IPA/SCCPlite The IPA/SCCPlite stacking is - as the name implies - constrained to the transport of SCCP messages. We have to reject any non-SCCP payload. Change-Id: I5e5a2879013ee8cf08aa4199b4bee498dcb61446 Fixes: OS#4235 --- M src/ipa.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/10/15810/1 diff --git a/src/ipa.c b/src/ipa.c index f3a7a52..d013916 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -57,6 +57,7 @@ int ipa_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua) { struct xua_msg_part *data_ie; + struct m3ua_data_hdr *data_hdr; struct msgb *msg; unsigned int src_len; const uint8_t *src; @@ -68,6 +69,13 @@ data_ie = xua_msg_find_tag(xua, M3UA_IEI_PROT_DATA); if (!data_ie || data_ie->len < sizeof(struct m3ua_data_hdr)) return -1; + data_hdr = (struct m3ua_data_hdr *) data_ie->dat; + + if (data_hdr->si != MTP_SI_SCCP) { + LOGPAS(as, DLSS7, LOGL_ERROR, "Cannot transmit non-SCCP SI (%u) to IPA peer\n", + data_hdr->si); + return -1; + } /* and even the data part still has the header prepended */ src = data_ie->dat + sizeof(struct m3ua_data_hdr); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5e5a2879013ee8cf08aa4199b4bee498dcb61446 Gerrit-Change-Number: 15810 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191019/dd7c8f9d/attachment.htm>