<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15810">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipa: Don't send non-SCCP data over IPA/SCCPlite<br><br>The IPA/SCCPlite stacking is - as the name implies - constrained to<br>the transport of SCCP messages. We have to reject any non-SCCP payload.<br><br>Change-Id: I5e5a2879013ee8cf08aa4199b4bee498dcb61446<br>Fixes: OS#4235<br>---<br>M src/ipa.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/10/15810/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipa.c b/src/ipa.c</span><br><span>index f3a7a52..d013916 100644</span><br><span>--- a/src/ipa.c</span><br><span>+++ b/src/ipa.c</span><br><span>@@ -57,6 +57,7 @@</span><br><span> int ipa_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua)</span><br><span> {</span><br><span>        struct xua_msg_part *data_ie;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct m3ua_data_hdr *data_hdr;</span><br><span>      struct msgb *msg;</span><br><span>    unsigned int src_len;</span><br><span>        const uint8_t *src;</span><br><span>@@ -68,6 +69,13 @@</span><br><span>     data_ie = xua_msg_find_tag(xua, M3UA_IEI_PROT_DATA);</span><br><span>         if (!data_ie || data_ie->len < sizeof(struct m3ua_data_hdr))</span><br><span>           return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    data_hdr = (struct m3ua_data_hdr *) data_ie->dat;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        if (data_hdr->si != MTP_SI_SCCP) {</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGPAS(as, DLSS7, LOGL_ERROR, "Cannot transmit non-SCCP SI (%u) to IPA peer\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                     data_hdr->si);</span><br><span style="color: hsl(120, 100%, 40%);">+             return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        /* and even the data part still has the header prepended */</span><br><span>  src = data_ie->dat + sizeof(struct m3ua_data_hdr);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15810">change 15810</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15810"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5e5a2879013ee8cf08aa4199b4bee498dcb61446 </div>
<div style="display:none"> Gerrit-Change-Number: 15810 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>