Change in ...osmo-bts[master]: L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15715 )

Change subject: L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default
......................................................................

L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default

We don't know whether a data block on PDCH belongs to PDTCH or PACCH
without parsing it, because the latter one is being allocated on
demand. Let's use GSMTAP_CHANNEL_PDTCH by default, rather than
GSMTAP_CHANNEL_PACCH.

Change-Id: I7639215ef936a8ac05ca417a91f4e12755f318d4
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 7d403f0..87ef01b 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -333,8 +333,10 @@
 	if (L1SAP_IS_PTCCH(fn)) {
 		*chan_type = GSMTAP_CHANNEL_PTCCH;
 		*ss = L1SAP_FN2PTCCHBLOCK(fn);
-	} else
-		*chan_type = GSMTAP_CHANNEL_PACCH;
+	} else {
+		/* TODO: distinguish PACCH */
+		*chan_type = GSMTAP_CHANNEL_PDTCH;
+	}
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15715
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7639215ef936a8ac05ca417a91f4e12755f318d4
Gerrit-Change-Number: 15715
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/a950da0e/attachment.htm>