<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15715">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">L1SAP: use GSMTAP_CHANNEL_PDTCH for PDTCH blocks by default<br><br>We don't know whether a data block on PDCH belongs to PDTCH or PACCH<br>without parsing it, because the latter one is being allocated on<br>demand. Let's use GSMTAP_CHANNEL_PDTCH by default, rather than<br>GSMTAP_CHANNEL_PACCH.<br><br>Change-Id: I7639215ef936a8ac05ca417a91f4e12755f318d4<br>---<br>M src/common/l1sap.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 7d403f0..87ef01b 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -333,8 +333,10 @@</span><br><span>        if (L1SAP_IS_PTCCH(fn)) {</span><br><span>            *chan_type = GSMTAP_CHANNEL_PTCCH;</span><br><span>           *ss = L1SAP_FN2PTCCHBLOCK(fn);</span><br><span style="color: hsl(0, 100%, 40%);">-  } else</span><br><span style="color: hsl(0, 100%, 40%);">-          *chan_type = GSMTAP_CHANNEL_PACCH;</span><br><span style="color: hsl(120, 100%, 40%);">+    } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* TODO: distinguish PACCH */</span><br><span style="color: hsl(120, 100%, 40%);">+         *chan_type = GSMTAP_CHANNEL_PDTCH;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15715">change 15715</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15715"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7639215ef936a8ac05ca417a91f4e12755f318d4 </div>
<div style="display:none"> Gerrit-Change-Number: 15715 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>