Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Oct 8 17:04:53 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 )

Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
......................................................................


Patch Set 5:

(1 comment)

mind the !

https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c 
File src/sgsn/sgsn_libgtp.c:

https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c@668 
PS5, Line 668:  != 
this gremlin here is well known.
it looked to me quite ugly to have
if (state == ..) {}
else { OSMO_ASSERT() }

ST_MM_IDLE should never get through this.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2019 17:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191008/5d78d29a/attachment.htm>


More information about the gerrit-log mailing list