<p style="white-space: pre-wrap; word-wrap: break-word;">mind the !</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15705">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c">File src/sgsn/sgsn_libgtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c@668">Patch Set #5, Line 668:</a> <code style="font-family:monospace,monospace"> != </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this gremlin here is well known.<br>it looked to me quite ugly to have<br>if (state == ..) {}<br>else { OSMO_ASSERT() }</p><p style="white-space: pre-wrap; word-wrap: break-word;">ST_MM_IDLE should never get through this.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15705">change 15705</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15705"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c </div>
<div style="display:none"> Gerrit-Change-Number: 15705 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 08 Oct 2019 17:04:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>