Change in ...osmo-ccid-firmware[master]: ccid_df: Ensure all three endpoints are correctly set

[laforge]

Hello Hoernchen,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644

to review the following change.


Change subject: ccid_df: Ensure all three endpoints are correctly set
......................................................................

ccid_df: Ensure all three endpoints are correctly set

The old code used to do OSMO_ASSERT(), i.e. checking if the
endpoint number was != 0.  However, now we're checking if it's
!= 0xFF, as the default initialization is 0xFF, and an unset
endpoint can be detected this way.

Change-Id: I7d334724a4c6b89ef8faa49bed49ed57ea216ff9
---
M sysmoOCTSIM/usb/class/ccid/device/ccid_df.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/44/15644/1

diff --git a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c
index 018208a..65d3499 100644
--- a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c
+++ b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c
@@ -91,9 +91,9 @@
 		ep = usb_find_ep_desc(usb_desc_next(desc->sod), desc->eod);
 	}
 
-	ASSERT(func_data->func_ep_irq);
-	ASSERT(func_data->func_ep_in);
-	ASSERT(func_data->func_ep_out);
+	ASSERT(func_data->func_ep_irq != 0xff);
+	ASSERT(func_data->func_ep_in != 0xff);
+	ASSERT(func_data->func_ep_out != 0xff);
 
 	_ccid_df_funcd.enabled = true;
 	return ERR_NONE;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I7d334724a4c6b89ef8faa49bed49ed57ea216ff9
Gerrit-Change-Number: 15644
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191001/4ba4d372/attachment.htm>