<p>laforge would like Hoernchen to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccid_df: Ensure all three endpoints are correctly set<br><br>The old code used to do OSMO_ASSERT(), i.e. checking if the<br>endpoint number was != 0.  However, now we're checking if it's<br>!= 0xFF, as the default initialization is 0xFF, and an unset<br>endpoint can be detected this way.<br><br>Change-Id: I7d334724a4c6b89ef8faa49bed49ed57ea216ff9<br>---<br>M sysmoOCTSIM/usb/class/ccid/device/ccid_df.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/44/15644/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c</span><br><span>index 018208a..65d3499 100644</span><br><span>--- a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c</span><br><span>+++ b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c</span><br><span>@@ -91,9 +91,9 @@</span><br><span>               ep = usb_find_ep_desc(usb_desc_next(desc->sod), desc->eod);</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ASSERT(func_data->func_ep_irq);</span><br><span style="color: hsl(0, 100%, 40%);">-      ASSERT(func_data->func_ep_in);</span><br><span style="color: hsl(0, 100%, 40%);">-       ASSERT(func_data->func_ep_out);</span><br><span style="color: hsl(120, 100%, 40%);">+    ASSERT(func_data->func_ep_irq != 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+    ASSERT(func_data->func_ep_in != 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+     ASSERT(func_data->func_ep_out != 0xff);</span><br><span> </span><br><span>       _ccid_df_funcd.enabled = true;</span><br><span>       return ERR_NONE;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644">change 15644</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15644"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7d334724a4c6b89ef8faa49bed49ed57ea216ff9 </div>
<div style="display:none"> Gerrit-Change-Number: 15644 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>