This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319 ) Change subject: fix the host/emulation build ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c File ccid_common/ccid_slot_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c@337 PS2, Line 337: char id_buf[3+2+1]; (a comment explaining magic nrs could be nice) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c@344 PS2, Line 344: I'm not sure if it is at all realistic, but code wise this could verify that cs->slot_nr is < 100 (2 digits) or alternatively check snprintf() return value? https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/iso7816_fsm.c File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/iso7816_fsm.c@1216 PS2, Line 1216: #if 0 never? then just drop it? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib07a58b6102b1709f295d08a764c6f118a2d0b9e Gerrit-Change-Number: 16319 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Sat, 30 Nov 2019 02:35:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/dad7390e/attachment.htm>