<p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c">File ccid_common/ccid_slot_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c@337">Patch Set #2, Line 337:</a> <code style="font-family:monospace,monospace">    char id_buf[3+2+1];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">(a comment explaining magic nrs could be nice)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/ccid_slot_fsm.c@344">Patch Set #2, Line 344:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure if it is at all realistic, but code wise this could verify that cs->slot_nr is < 100 (2 digits) or alternatively check snprintf() return value?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/iso7816_fsm.c">File ccid_common/iso7816_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319/2/ccid_common/iso7816_fsm.c@1216">Patch Set #2, Line 1216:</a> <code style="font-family:monospace,monospace">#if 0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">never? then just drop it?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319">change 16319</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib07a58b6102b1709f295d08a764c6f118a2d0b9e </div>
<div style="display:none"> Gerrit-Change-Number: 16319 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 30 Nov 2019 02:35:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>