Change in libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 )

Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc
......................................................................


Patch Set 7:

(8 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@175 
PS7, Line 175: Enable
If there is a way to enable this feature, shouldn't there be a way to disable it?


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@195 
PS7, Line 195: line->driver->name, VTY_NEWLINE);
Cosmetic: alignment.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@282 
PS7, Line 282: 					line->ipa_kap->interval, line->ipa_kap->wait_for_resp,
Cosmetic: alignment.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c 
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@65 
PS7, Line 65:    
Please use tabs.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@65 
PS7, Line 65: int
bool?


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@103 
PS7, Line 103:  {
coding style


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@105 
PS7, Line 105: send
Cosmetic (not a merge blocker): send() without flags equals to write().


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@109 
PS7, Line 109:  {
coding style



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a
Gerrit-Change-Number: 14743
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 29 Nov 2019 16:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191129/2ea2d169/attachment.htm>