<p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c">File src/e1_input_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@175">Patch Set #7, Line 175:</a> <code style="font-family:monospace,monospace">Enable</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If there is a way to enable this feature, shouldn't there be a way to disable it?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@195">Patch Set #7, Line 195:</a> <code style="font-family:monospace,monospace">line->driver->name, VTY_NEWLINE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Cosmetic: alignment.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/e1_input_vty.c@282">Patch Set #7, Line 282:</a> <code style="font-family:monospace,monospace">                                 line->ipa_kap->interval, line->ipa_kap->wait_for_resp,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Cosmetic: alignment.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c">File src/input/ipaccess.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@65">Patch Set #7, Line 65:</a> <code style="font-family:monospace,monospace">   </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please use tabs.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@65">Patch Set #7, Line 65:</a> <code style="font-family:monospace,monospace">int</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">bool?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@103">Patch Set #7, Line 103:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">coding style</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@105">Patch Set #7, Line 105:</a> <code style="font-family:monospace,monospace">send</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Cosmetic (not a merge blocker): send() without flags equals to write().</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743/7/src/input/ipaccess.c@109">Patch Set #7, Line 109:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">coding style</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743">change 14743</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/14743"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a </div>
<div style="display:none"> Gerrit-Change-Number: 14743 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 Nov 2019 16:51:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>