This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314 ) Change subject: library/MNCC_Types: fix sdp in tr_MNCC_* ...................................................................... library/MNCC_Types: fix sdp in tr_MNCC_* Make sure it is * everywhere, not "". Partially fix the SIP tests, where tr_MNCC_RTP_CONNECT did not match anymore: 13:15:27.516387 5 SIP_Tests.ttcn:219 Message enqueued on MNCC from SIP_Test-MNCC(3) @MNCC_Types.MNCC_PDU : { msg_type := MNCC_RTP_CONNECT (517), u := { rtp := { callref := 5001, ip := 0, rtp_port := 0, payload_type := 0, payload_msg_type := 0, sdp := "0" } } } id 3 13:15:27.516604 5 SIP_Tests.ttcn:221 Matching on port MNCC .u.rtp.sdp := "0" with "" unmatched: First message in the queue does not match the template: Together with I522ce7f206932a816a64f03d916799c3215bb8c7 in osmo-sip-connector.git, this makes the testsuite work again for osmo-sip-connector master. In order to fix the TTCN-3 tests for the latest release, we would need to add a second code path to the TTCN-3 code, that does not send the sdp data based on a configuration option. Considering that I've spent quite some time already to fix this up, it does not seem worth the effort. Related: OS#4282 Fixes: 06b859ca314f53a902329ed95848dbafef1d4f87 ("msc: add sdp to MNCC") Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e --- M library/MNCC_Types.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/16314/1 diff --git a/library/MNCC_Types.ttcn b/library/MNCC_Types.ttcn index 5296579..0a8e7d9 100644 --- a/library/MNCC_Types.ttcn +++ b/library/MNCC_Types.ttcn @@ -1478,7 +1478,7 @@ imsi := ?, lchan_type := 0, lchan_mode := 0, - sdp := "" + sdp := * } } } @@ -1856,7 +1856,7 @@ imsi := "", lchan_type := 0, lchan_mode := 0, - sdp := "" + sdp := * } } } @@ -1977,7 +1977,7 @@ rtp_port := rtp_port, payload_type := pt, payload_msg_type := 0, - sdp := "" + sdp := * } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e Gerrit-Change-Number: 16314 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/79882ad1/attachment.htm>