<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/MNCC_Types: fix sdp in tr_MNCC_*<br><br>Make sure it is * everywhere, not "". Partially fix the SIP tests, where<br>tr_MNCC_RTP_CONNECT did not match anymore:<br><br>13:15:27.516387 5 SIP_Tests.ttcn:219 Message enqueued on MNCC from SIP_Test-MNCC(3) @MNCC_Types.MNCC_PDU : {<br>    msg_type := MNCC_RTP_CONNECT (517),<br>    u := {<br>        rtp := {<br>            callref := 5001,<br>            ip := 0,<br>            rtp_port := 0,<br>            payload_type := 0,<br>            payload_msg_type := 0,<br>            sdp := "0"<br>        }<br>    }<br>} id 3<br>13:15:27.516604 5 SIP_Tests.ttcn:221 Matching on port MNCC .u.rtp.sdp := "0" with "" unmatched: First message in the queue does not match the template:<br><br>Together with I522ce7f206932a816a64f03d916799c3215bb8c7 in<br>osmo-sip-connector.git, this makes the testsuite work again for<br>osmo-sip-connector master.<br><br>In order to fix the TTCN-3 tests for the latest release, we would need<br>to add a second code path to the TTCN-3 code, that does not send the sdp<br>data based on a configuration option. Considering that I've spent quite<br>some time already to fix this up, it does not seem worth the effort.<br><br>Related: OS#4282<br>Fixes: 06b859ca314f53a902329ed95848dbafef1d4f87 ("msc: add sdp to MNCC")<br>Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e<br>---<br>M library/MNCC_Types.ttcn<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/16314/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/MNCC_Types.ttcn b/library/MNCC_Types.ttcn</span><br><span>index 5296579..0a8e7d9 100644</span><br><span>--- a/library/MNCC_Types.ttcn</span><br><span>+++ b/library/MNCC_Types.ttcn</span><br><span>@@ -1478,7 +1478,7 @@</span><br><span>                   imsi := ?,</span><br><span>                   lchan_type := 0,</span><br><span>                     lchan_mode := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                        sdp := ""</span><br><span style="color: hsl(120, 100%, 40%);">+                   sdp := *</span><br><span>             }</span><br><span>    }</span><br><span> }</span><br><span>@@ -1856,7 +1856,7 @@</span><br><span>                       imsi := "",</span><br><span>                        lchan_type := 0,</span><br><span>                     lchan_mode := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                        sdp := ""</span><br><span style="color: hsl(120, 100%, 40%);">+                   sdp := *</span><br><span>             }</span><br><span>    }</span><br><span> }</span><br><span>@@ -1977,7 +1977,7 @@</span><br><span>                       rtp_port := rtp_port,</span><br><span>                        payload_type := pt,</span><br><span>                  payload_msg_type := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                  sdp := ""</span><br><span style="color: hsl(120, 100%, 40%);">+                   sdp := *</span><br><span>             }</span><br><span>    }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314">change 16314</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e </div>
<div style="display:none"> Gerrit-Change-Number: 16314 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>