Change in osmo-ccid-firmware[master]: cuart cleanup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 26 23:26:28 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251 )

Change subject: cuart cleanup
......................................................................


Patch Set 1:

(1 comment)

commit log too short. I also think it's not just a cleanup, but actually mixes code cleanup with addition of orthogonal new features. Should be separate.

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251/1/ccid_common/cuart.h 
File ccid_common/cuart.h:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251/1/ccid_common/cuart.h@29 
PS1, Line 29: 	CUART_CTL_SET_CLOCK_FREQ, /* set ICC clock frequency (hz)*/
that pure renaming of existinv values (CLOCK_FREQ->SET_CLOCK_FREQ, CTL_FD->CTL_SET_FD) could be a separate patch that precedes the another which adds new functionality like get_baudrate and get_clock_Freq



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ia5b66a86f0f53e5123139c3c5047f70582d1bf6e
Gerrit-Change-Number: 16251
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 26 Nov 2019 23:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/609da7e1/attachment.htm>


More information about the gerrit-log mailing list