<p style="white-space: pre-wrap; word-wrap: break-word;">commit log too short. I also think it's not just a cleanup, but actually mixes code cleanup with addition of orthogonal new features. Should be separate.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251/1/ccid_common/cuart.h">File ccid_common/cuart.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251/1/ccid_common/cuart.h@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace">       CUART_CTL_SET_CLOCK_FREQ, /* set ICC clock frequency (hz)*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that pure renaming of existinv values (CLOCK_FREQ->SET_CLOCK_FREQ, CTL_FD->CTL_SET_FD) could be a separate patch that precedes the another which adds new functionality like get_baudrate and get_clock_Freq</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251">change 16251</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia5b66a86f0f53e5123139c3c5047f70582d1bf6e </div>
<div style="display:none"> Gerrit-Change-Number: 16251 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Nov 2019 23:26:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>